Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decimal in table viz #10439

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Decimal in table viz #10439

merged 1 commit into from
Jul 4, 2024
+11 −2

Conversation

marthasharkey
Copy link
Contributor

@marthasharkey marthasharkey commented Jul 3, 2024 •
edited
Loading

image

Right aligns decimal and de-serialises the decimal object

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.

@marthasharkey marthasharkey marked this pull request as ready for review July 4, 2024 13:11
@marthasharkey marthasharkey added CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge labels Jul 4, 2024
@mergify mergify bot merged commit ee44aec into develop Jul 4, 2024
37 of 38 checks passed
@mergify mergify bot deleted the wip/mk/decimal-table-viz branch July 4, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazcw kazcw kazcw approved these changes

@Frizi Frizi Awaiting requested review from Frizi Frizi is a code owner

@farmaazon farmaazon Awaiting requested review from farmaazon farmaazon is a code owner

@vitvakatu vitvakatu Awaiting requested review from vitvakatu vitvakatu is a code owner

@AdRiley AdRiley Awaiting requested review from AdRiley AdRiley is a code owner

Assignees
No one assigned
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marthasharkey @kazcw